Use chunks in DynamicWhereFilter, fix a chunk leak, and cleanup some code generally #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
added
query engine
core
devinrsmith
reviewed
Nov 14, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/select/DynamicWhereFilter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/DynamicWhereFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/DynamicWhereFilter.java
Show resolved
Hide resolved
Comment on lines
+302
to
+304
| final Chunk<Values> keyChunk = Chunk.downcast(tupleSource.getChunk(keyGetContext, selectionChunk)); | ||
| final int thisChunkSize = keyChunk.size(); | ||
| setInclusionKernel.matchValues(keyChunk, matches); |
There was a problem hiding this comment.
There isn't anything "special" about SetInclusionKernel; do we always know it will be an object chunk now?
There doesn't seem to be any value in copying into matches, to then just use it later as filter. I think we can simply check against liveValues as we iterate and build index.
There was a problem hiding this comment.
Because I combined the single column case and the tuple case, we do not know it will always be an object chunk. Set inclusion let's us do non-boxing inclusion tests. That is, it is special.
engine/table/src/main/java/io/deephaven/engine/table/impl/select/DynamicWhereFilter.java
Show resolved
Hide resolved
devinrsmith
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.