Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS API must support SKIP as an aggregation type #4780

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Nov 6, 2023

Fixes #4182

@niloc132 niloc132 added this to the November 2023 milestone Nov 6, 2023
@niloc132 niloc132 requested a review from mofojed November 6, 2023 22:46
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested with the steps in the ticket #4182 but with this snippet specifying the defaultOperation:

// `temp1` should be the name of your global variable the table is assigned to
var totalsTable = await temp1.getTotalsTable({ defaultOperation: 'Skip', operationMap: { I: ['Sum', 'Count'] } })
console.log('totals columns: ', totalsTable.columns.map(c => c.name))

I do find it slightly odd that our default operation is Sum instead of Skip, but that seems to be consistent with Enterprise.

@niloc132 niloc132 merged commit a52c2fe into deephaven:main Nov 16, 2023
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way for UI to specify skipping a column in aggregations
2 participants