-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Groovy container w/ examples and Redpanda #4673
Conversation
…es and change docker-compose to docker compose in shell commands
This PR now not only adds a Groovy-examples-redpanda docker compose deployment, it also adds:
It also removes any |
I should also mention this removes our All-AI deployments, as we decided to no longer publish those images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments that I think apply to a lot of files - didn't repeat the advice for every single file though...
command: | ||
- redpanda | ||
- start | ||
- --smp | ||
- '1' | ||
- --reserve-memory | ||
- 0M | ||
- --overprovisioned | ||
- --node-id | ||
- '0' | ||
- --kafka-addr | ||
- PLAINTEXT://0.0.0.0:29092,OUTSIDE://0.0.0.0:9092 | ||
- --advertise-kafka-addr | ||
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should adopt the formatting style redpanda uses for this:
command:
- redpanda
- start
- --kafka-addr internal://0.0.0.0:9092,external://0.0.0.0:19092
- --advertise-kafka-addr internal://redpanda:9092,external://localhost:19092
- --schema-registry-addr internal://0.0.0.0:8081,external://0.0.0.0:18081
- --smp 1
- --memory 1G
- --mode dev-container
I've modified this from https://docs.redpanda.com/current/get-started/quick-start/; we should test it in all of the different compose files to make sure it works. Do we use the schema registry for any of our examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do. I've made updates that make our syntax consistent with Redpanda and tested it to make sure it works with the examples in our Kafka documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we're consistent w/ the redpanda quickstart - they use internal
and external
, and use dev-container
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See item I re-opened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you've run these examples successfully, LGTM.
We're adding Kafka Groovy docs, so having this to link to will be helpful, even if it's basically identical to the Python one.