Skip to content

Commit

Permalink
fix(cppclient): Clarify a comment explaining why a test is disabled, … (
Browse files Browse the repository at this point in the history
#5705)

…and fix a bug in the test
  • Loading branch information
kosak committed Jul 2, 2024
1 parent 1e56a5b commit cd5abf8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions cpp-client/deephaven/tests/src/ungroup_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@
#include "deephaven/tests/test_util.h"

namespace deephaven::client::tests {
// TODO(kosak): This test is currently disabled (by membership in the [.] test group, because we
// don't yet deserialize the grouped column correctly.
// TODO(kosak): This test is currently disabled (by membership in the [.] test group).
// The reason is because each cell in the grouped column comes back as the Arrow type list<double>,
// but the library does not currently know how to deserialize Arrow list types.
TEST_CASE("Ungroup columns", "[.]") {
auto tm = TableMakerForTests::Create();
auto table = tm.Table();

table = table.Where("ImportDate == `2017-11-01`");

auto by_table = table.Where("Ticker == `AAPL`").View("Ticker", "Close").View("Ticker");
auto by_table = table.Where("Ticker == `AAPL`").View("Ticker", "Close").By("Ticker");
std::cout << by_table.Stream(true) << '\n';
auto ungrouped = by_table.Ungroup("Close");

std::vector<std::string> ticker_data = {"AAPL"};
Expand Down

0 comments on commit cd5abf8

Please sign in to comment.