Skip to content

Commit

Permalink
Minor tweaks for readability
Browse files Browse the repository at this point in the history
  • Loading branch information
malhotrashivam committed Nov 9, 2023
1 parent 9b73db5 commit a48ea8d
Showing 1 changed file with 10 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -351,14 +351,17 @@ public Optional<Class<?>> visit(final LogicalTypeAnnotation.TimeLogicalTypeAnnot
@Override
public Optional<Class<?>> visit(
final LogicalTypeAnnotation.TimestampLogicalTypeAnnotation timestampLogicalType) {
final LogicalTypeAnnotation.TimeUnit unit = timestampLogicalType.getUnit();
final boolean isAdjustedToUTC = timestampLogicalType.isAdjustedToUTC();
if (unit != LogicalTypeAnnotation.TimeUnit.MILLIS && unit != LogicalTypeAnnotation.TimeUnit.MICROS
&& unit != LogicalTypeAnnotation.TimeUnit.NANOS) {
errorString.setValue("TimestampLogicalType, isAdjustedToUTC=" + isAdjustedToUTC + ", unit=" + unit);
return Optional.empty();
switch (timestampLogicalType.getUnit()) {
case MILLIS:
case MICROS:
case NANOS:
// TIMESTAMP fields if adjusted to UTC are read as Instants, else as LocalDatetimes.
return timestampLogicalType.isAdjustedToUTC() ? Optional.of(Instant.class)
: Optional.of(LocalDateTime.class);
}
return isAdjustedToUTC ? Optional.of(Instant.class) : Optional.of(LocalDateTime.class);
errorString.setValue("TimestampLogicalType, isAdjustedToUTC=" + timestampLogicalType.isAdjustedToUTC()
+ ", unit=" + timestampLogicalType.getUnit());
return Optional.empty();
}

@Override
Expand Down

0 comments on commit a48ea8d

Please sign in to comment.