Also on completeExceptionally

deephaven · Dec 13, 2023 · 9a0fd32 · 9a0fd32
1 parent b284a47
commit 9a0fd32
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java b/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java
@@ -388,6 +388,12 @@ public boolean cancel(boolean mayInterruptIfRunning) {
             return false;
         }
 
+        @Override
+        public boolean completeExceptionally(Throwable ex) {
+            maybeRelease();
+            return super.completeExceptionally(ex);
+        }
+
         @Override
         public Table get(final long timeout, @NotNull final TimeUnit unit)
                 throws InterruptedException, ExecutionException, TimeoutException {

diff --git a/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java b/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
@@ -486,6 +486,12 @@ public boolean cancel(boolean mayInterruptIfRunning) {
             return false;
         }
 
+        @Override
+        public boolean completeExceptionally(Throwable ex) {
+            maybeRelease();
+            return super.completeExceptionally(ex);
+        }
+
         @Override
         public Table get(final long timeout, @NotNull final TimeUnit unit)
                 throws InterruptedException, ExecutionException, TimeoutException {
@@ -556,6 +562,12 @@ public boolean cancel(boolean mayInterruptIfRunning) {
             return false;
         }
 
+        @Override
+        public boolean completeExceptionally(Throwable ex) {
+            maybeRelease();
+            return super.completeExceptionally(ex);
+        }
+
         @Override
         public Table get(final long timeout, @NotNull final TimeUnit unit)
                 throws InterruptedException, ExecutionException, TimeoutException {