Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
chipkent committed Nov 29, 2023
1 parent f77e453 commit 993f9f6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ public BusinessCalendar(final String name, final String description, final ZoneI
this.firstValidDate = firstValidDate;
this.lastValidDate = lastValidDate;
this.standardBusinessDay = standardBusinessDay;
this.weekendDays = weekendDays;
this.holidays = holidays;
this.weekendDays = Set.copyOf(weekendDays);
this.holidays = Map.copyOf(holidays);
populateSchedules();
populateCachedYearData();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ private static void load(final String businessCalendarConfig) throws NoSuchFileE
final InputStream inputStream = Calendars.class.getResourceAsStream(filePath);
if (inputStream != null) {
final File calendarFile = inputStreamToFile(inputStream);
final BusinessCalendar businessCalendar = BusinessCalendarXMLParser.loadBusinessCalendar(calendarFile);
final BusinessCalendar businessCalendar =
BusinessCalendarXMLParser.loadBusinessCalendar(calendarFile);
addCalendar(businessCalendar);
// noinspection ResultOfMethodCallIgnored
calendarFile.delete();
Expand Down

0 comments on commit 993f9f6

Please sign in to comment.