Skip to content

Commit

Permalink
Review response
Browse files Browse the repository at this point in the history
  • Loading branch information
devinrsmith committed Nov 15, 2023
1 parent 4ce2e76 commit 564530c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ public boolean publishInitial() {
/**
* The partition column. When set, uses the the given {@code int} column from {@link #table()} as the first source
* for setting the kafka record partition. When not present, or the column value is null, {@link #partition()} will
* be used if present. If a valid partition number is specified that partition will be used when sending the record.
* If no partition is specified but a key is present a partition will be chosen using a hash of the key. If neither
* key nor partition is present a partition will be assigned in a round-robin fashion.
* be used if present. If a valid partition number is specified, that partition will be used when sending the
* record. If no partition is specified but a key is present, a partition will be chosen using a hash of the key. If
* neither key nor partition is present, a partition will be assigned in a round-robin fashion.
*
* @return the partition column name
*/
Expand Down
6 changes: 3 additions & 3 deletions py/server/deephaven/stream/kafka/producer.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ def produce(
will be used.
partition_column (Optional[str]): the partition column, None by default. When set, uses the the given int column
from table as the first source for setting the kafka record partition. When None, or the column value is null,
partition will be used if present. If a valid partition number is specified that partition will be used when
sending the record. If no partition is specified but a key is present a partition will be chosen using a hash
of the key. If neither key nor partition is present a partition will be assigned in a round-robin fashion.
partition will be used if present. If a valid partition number is specified, that partition will be used when
sending the record. If no partition is specified but a key is present, a partition will be chosen using a hash
of the key. If neither key nor partition is present, a partition will be assigned in a round-robin fashion.
timestamp_column (Optional[str]): the timestamp column, None by default. When set, uses the the given timestamp
column from table as the first source for setting the kafka record timestamp. When None, or the column value
is null, the producer will stamp the record with its current time. The timestamp eventually used by Kafka
Expand Down

0 comments on commit 564530c

Please sign in to comment.