Skip to content

Commit

Permalink
fix: Add a missing numba dependency check (#6015)
Browse files Browse the repository at this point in the history
Found this bug when testing Python 3.13.0rc1.
  • Loading branch information
jmao-denver authored Sep 3, 2024
1 parent f3b4ce7 commit 38fa28a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion py/server/deephaven/_udf.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,11 @@ def prepare_auto_arg_conv(self, encoded_arg_types: str) -> bool:
parameters."""
# numba and numpy ufuncs don't need auto argument conversion as they handle the conversion themselves and the
# arg types are already verified by the query engine
if isinstance(self.fn, (numba.np.ufunc.gufunc.GUFunc, numba.np.ufunc.dufunc.DUFunc)) or isinstance(self.fn, numpy.ufunc):
if numba:
if isinstance(self.fn, (numba.np.ufunc.gufunc.GUFunc, numba.np.ufunc.dufunc.DUFunc)):
return False

if isinstance(self.fn, numpy.ufunc):
return False

if not self.params or not encoded_arg_types:
Expand Down

0 comments on commit 38fa28a

Please sign in to comment.