Skip to content

Commit

Permalink
Addressing code review.
Browse files Browse the repository at this point in the history
  • Loading branch information
chipkent committed Nov 20, 2023
1 parent 70dd8cb commit 26bc1c4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
~ Copyright (c) 2016-2021 Deephaven Data Labs and Patent Pending
~ Copyright (c) 2016-2023 Deephaven Data Labs and Patent Pending
-->

<calendar>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
~ Copyright (c) 2016-2021 Deephaven Data Labs and Patent Pending
~ Copyright (c) 2016-2023 Deephaven Data Labs and Patent Pending
-->

<calendar>
Expand Down
4 changes: 3 additions & 1 deletion py/server/tests/test_calendar.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def get_resource_path(self, resource_path) -> str:
Objects = jpy.get_type("java.util.Objects")
return Paths.get(Objects.requireNonNull(obj.getClass().getResource(resource_path)).toURI()).toString()

def test_add_calendar(self):
def test_add_remove_calendar(self):
path1 = self.get_resource_path("/TEST1.calendar")
path2 = self.get_resource_path("/TEST2.calendar")

Expand All @@ -44,6 +44,8 @@ def test_add_calendar(self):
add_calendar(cal=cal)
self.assertIn("TEST2", calendar_names())

# Testing calendar removal here so that the global calendar state is not affected by the test

remove_calendar("TEST1")
remove_calendar("TEST2")

Expand Down

0 comments on commit 26bc1c4

Please sign in to comment.