-
Notifications
You must be signed in to change notification settings - Fork 80
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always export scope objects before performing other interactions (#4816)
Fixes #4604
- Loading branch information
Showing
4 changed files
with
128 additions
and
68 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
web/client-api/src/main/java/io/deephaven/web/client/api/impl/TicketAndPromise.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package io.deephaven.web.client.api.impl; | ||
|
|
||
| import elemental2.promise.IThenable; | ||
| import elemental2.promise.Promise; | ||
| import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.ticket_pb.Ticket; | ||
| import io.deephaven.web.client.api.WorkerConnection; | ||
| import io.deephaven.web.shared.fu.JsFunction; | ||
|
|
||
| /** | ||
| * Pair of ticket and the promise that indicates it has been resolved. Tickets are usable before they are resolved, but | ||
| * to ensure that all operations completed successfully, the promise should be used to handle errors. | ||
| */ | ||
| public class TicketAndPromise<T> implements IThenable<T> { | ||
| private final Ticket ticket; | ||
| private final Promise<T> promise; | ||
| private final WorkerConnection connection; | ||
| private boolean released = false; | ||
|
|
||
| public TicketAndPromise(Ticket ticket, Promise<T> promise, WorkerConnection connection) { | ||
| this.ticket = ticket; | ||
| this.promise = promise; | ||
| this.connection = connection; | ||
| } | ||
|
|
||
| public TicketAndPromise(Ticket ticket, WorkerConnection connection) { | ||
| this(ticket, (Promise<T>) Promise.resolve(ticket), connection); | ||
| } | ||
|
|
||
| public Promise<T> promise() { | ||
| return promise; | ||
| } | ||
|
|
||
| public Ticket ticket() { | ||
| return ticket; | ||
| } | ||
|
|
||
| @Override | ||
| public <V> TicketAndPromise<V> then(ThenOnFulfilledCallbackFn<? super T, ? extends V> onFulfilled) { | ||
| return new TicketAndPromise<>(ticket, promise.then(onFulfilled), connection); | ||
| } | ||
|
|
||
| /** | ||
| * Rather than waiting for the original promise to succeed, lets the caller start a new call based only on the | ||
| * original ticket. The intent of "race" here is unlike Promise.race(), where the first to succeed should resolve - | ||
| * instead, this raced call will be sent to the server even though the previous call has not successfully returned, | ||
| * and the server is responsible for ensuring they happen in the correct order. | ||
| * | ||
| * @param racedCall the call to perform at the same time that any pending call is happening | ||
| * @return a new TicketAndPromise that will resolve when all work is successful | ||
| * @param <V> type of the next call to perform | ||
| */ | ||
| public <V> TicketAndPromise<V> race(JsFunction<Ticket, IThenable<V>> racedCall) { | ||
| IThenable<V> raced = racedCall.apply(ticket); | ||
| return new TicketAndPromise<>(ticket, Promise.all(promise, raced).then(ignore -> raced), connection); | ||
| } | ||
|
|
||
| @Override | ||
| public <V> IThenable<V> then(ThenOnFulfilledCallbackFn<? super T, ? extends V> onFulfilled, | ||
| ThenOnRejectedCallbackFn<? extends V> onRejected) { | ||
| return promise.then(onFulfilled, onRejected); | ||
| } | ||
|
|
||
| public void release() { | ||
| if (!released) { | ||
| // don't double-release, in cases where the same ticket is used for multiple parts of the request | ||
| released = true; | ||
| connection.releaseTicket(ticket); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.