Skip to content

Commit

Permalink
Add signatureHelp and hover to Python autocomplete (#3607)
Browse files Browse the repository at this point in the history
Corresponds with deephaven/web-client-ui#1178

This addresses the first 3 items in #3453 except deprecation tags.

Adds signatureHelp and hover requests to the Python autocomplete server

Requires you build and force reinstall the Python server locally unless you are using pip -e flag for your local Python server.

Put the plumbing in place for autocomplete cancellation and diagnostic requests
  • Loading branch information
mattrunyon committed Mar 31, 2023
1 parent c04ceaf commit 05fcdad
Show file tree
Hide file tree
Showing 48 changed files with 29,574 additions and 9,804 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.deephaven.auth.ServiceAuthWiring;
import io.deephaven.proto.backplane.script.grpc.AutoCompleteRequest;
import io.deephaven.proto.backplane.script.grpc.BindTableToVariableRequest;
import io.deephaven.proto.backplane.script.grpc.CancelAutoCompleteRequest;
import io.deephaven.proto.backplane.script.grpc.CancelCommandRequest;
import io.deephaven.proto.backplane.script.grpc.ConsoleServiceGrpc;
import io.deephaven.proto.backplane.script.grpc.ExecuteCommandRequest;
Expand Down Expand Up @@ -52,6 +53,8 @@ default ServerServiceDefinition intercept(ConsoleServiceGrpc.ConsoleServiceImplB
serviceBuilder.addMethod(ServiceAuthWiring.intercept(
service, "AutoCompleteStream", this::onCallStartedAutoCompleteStream,
this::onMessageReceivedAutoCompleteStream));
serviceBuilder.addMethod(ServiceAuthWiring.intercept(
service, "CancelAutoComplete", null, this::onMessageReceivedCancelAutoComplete));
serviceBuilder.addMethod(ServiceAuthWiring.intercept(
service, "OpenAutoCompleteStream", null, this::onMessageReceivedOpenAutoCompleteStream));
serviceBuilder.addMethod(ServiceAuthWiring.intercept(
Expand Down Expand Up @@ -141,6 +144,16 @@ void onMessageReceivedBindTableToVariable(AuthContext authContext,
*/
void onMessageReceivedAutoCompleteStream(AuthContext authContext, AutoCompleteRequest request);

/**
* Authorize a request to CancelAutoComplete.
*
* @param authContext the authentication context of the request
* @param request the request to authorize
* @throws io.grpc.StatusRuntimeException if the user is not authorized to invoke CancelAutoComplete
*/
void onMessageReceivedCancelAutoComplete(AuthContext authContext,
CancelAutoCompleteRequest request);

/**
* Authorize a request to OpenAutoCompleteStream.
*
Expand Down Expand Up @@ -187,6 +200,9 @@ public void onCallStartedAutoCompleteStream(AuthContext authContext) {}
public void onMessageReceivedAutoCompleteStream(AuthContext authContext,
AutoCompleteRequest request) {}

public void onMessageReceivedCancelAutoComplete(AuthContext authContext,
CancelAutoCompleteRequest request) {}

public void onMessageReceivedOpenAutoCompleteStream(AuthContext authContext,
AutoCompleteRequest request) {}

Expand Down Expand Up @@ -238,6 +254,11 @@ public void onMessageReceivedAutoCompleteStream(AuthContext authContext,
ServiceAuthWiring.operationNotAllowed();
}

public void onMessageReceivedCancelAutoComplete(AuthContext authContext,
CancelAutoCompleteRequest request) {
ServiceAuthWiring.operationNotAllowed();
}

public void onMessageReceivedOpenAutoCompleteStream(AuthContext authContext,
AutoCompleteRequest request) {
ServiceAuthWiring.operationNotAllowed();
Expand Down Expand Up @@ -313,6 +334,13 @@ public void onMessageReceivedAutoCompleteStream(AuthContext authContext,
}
}

public void onMessageReceivedCancelAutoComplete(AuthContext authContext,
CancelAutoCompleteRequest request) {
if (delegate != null) {
delegate.onMessageReceivedCancelAutoComplete(authContext, request);
}
}

public void onMessageReceivedOpenAutoCompleteStream(AuthContext authContext,
AutoCompleteRequest request) {
if (delegate != null) {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 05fcdad

Please sign in to comment.