Remove CSPP server options. #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSPP server options have become redundant since the introduction of peer-to-peer mixing, but in some places the value of csppserver was still used to toggle mixing on/off. This behaviour is more properly implemented using a boolean. Breaking changes: - Removed deprecated configs `--csppserver` and `--csppserver.ca`. - `cspp_server` parameter replaced by `enable_mixing` in `purchasetickets` and `runticketbuyer` gRPCs. - `cspp_server` parameter removed from `runaccountmixer` gRPC.
jholdstock
force-pushed
the
rm-cspp-server
branch
from
b49dccc
to
669f767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2417
The CSPP server options have become redundant since the introduction of peer-to-peer mixing, but in some places the value of csppserver was still used to toggle mixing on/off. This behaviour is more properly implemented using a boolean.
Breaking changes:
--csppserverand--csppserver.ca.cspp_serverparameter replaced byenable_mixinginpurchaseticketsandrunticketbuyergRPCs.cspp_serverparameter removed fromrunaccountmixergRPC.