Cleanup ticket buyer v2 #2412
Merged
Cleanup ticket buyer v2 #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of TicketBuyerService was removed by 3a69079, thus there is no reason to keep the API definition in the proto file.
There is currently only a single implementation of ticket buyer, and all references to old implementations have been removed. There is therefore no longer any need to reference v2 (or even v3) ticket buyers.
jholdstock
force-pushed
the
cleanup-tb
branch
from
adf2fa8
to
37fc7af
Compare
jrick
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently only a single implementation of ticket buyer so references to v2 (or even v3) only serve to cause confusion.
Based on #2411 which bumps gRPC server version to 8.0.0.