Set complete=false in redeemmultisigout on invalid sigs #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
Jul 26, 2023
If the raw transaction provided by the caller contains invalid signatures, set complete=false to indicate that the transaction is not ready to send. This situation (where the user has manually modified the transaction after a previous redeemmultisigout call, which may add some of the required signatures) is unfortunate and there are possibly better ways we could deal with this, such as removing the invalid signature, or returning a more descriptive error for the failed script evaluation.
jrick
force-pushed
the
redeemmultisig-invalidsig
branch
from
ec3a3e7
to
0a63be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the raw transaction provided by the caller contains invalid signatures, set complete=false to indicate that the transaction is not ready to send.
This situation (where the user has manually modified the transaction after a previous redeemmultisigout call, which may add some of the required signatures) is unfortunate and there are possibly better ways we could deal with this, such as removing the invalid signature, or returning a more descriptive error for the failed script evaluation.
Refs #2273