Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: add listtickets json rpc command #1169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kLkA
Copy link
Contributor

@kLkA kLkA commented Jun 6, 2018

listtickets cmd return detailed info about ticket details, spender
and state

#1168

@kLkA kLkA force-pushed the add_listalltickets_rpc_method branch 8 times, most recently from 324fb19 to 76651ee Compare June 9, 2018 15:22
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to hold off on this until SPV lands. We need to reconsider the results since SPV wallets won't know as much about the state of matured tickets.

if connected {
chainClient, err = chain.RPCClientFromBackend(n)
if err != nil {
err := chainClient.Ping()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will panic dereferencing a nil pointer

@kLkA kLkA force-pushed the add_listalltickets_rpc_method branch 2 times, most recently from f57a098 to ab1a1f6 Compare September 22, 2018 16:01
@kLkA
Copy link
Contributor Author

kLkA commented Sep 22, 2018

@jrick I'm ready to hear for you notions after SPV is ready, to pass CI decred/dcrd#1267 changes have to be deployed on dcrd project

@kLkA kLkA force-pushed the add_listalltickets_rpc_method branch 2 times, most recently from 44e6e56 to f273423 Compare October 2, 2018 20:35
listtickets return detailed info about ticket details, spender
and status.
@kLkA kLkA force-pushed the add_listalltickets_rpc_method branch from f273423 to 5fb3f09 Compare October 6, 2018 09:52
@kLkA
Copy link
Contributor Author

kLkA commented Oct 11, 2018

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants