pool: Cleanup client read error logging. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
pool_cleanup_read_err_logging
branch
from
64250f3
to
2c4dd87
Compare
This ensures the send to the read channel for a client respects the context since it could otherwise end up hanging forever when sending to the channel that no longer has a goroutine reading from it thereby leaking the goroutine. It also includes the read goroutine in the overall waitgroup for the client to help ensure it shuts down as intended.
This switches the code that examines read errors for timeout to use the proper interface from the net package that is designed for that purpose instead of digging into concrete types. It also ensures clients that timeout without ever identifying themselves have their uniquely-assigned extra nonce used as the id instead so the log messages can be attributed to the ip of the offending clients. Finally, it no longer logs an error when an io.EOF is encountered as that is an expected condition when the client disconnects and is not an actual error.
davecgh
force-pushed
the
pool_cleanup_read_err_logging
branch
from
2c4dd87
to
84cc283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #375.
This switches the code that examines read errors for timeout to use the proper interface from the net package that is designed for that purpose instead of digging into concrete types.
It also ensures clients that timeout without ever identifying themselves have their uniquely-assigned extra nonce used as the id instead so the log messages can be attributed to the ip of the offending clients.
Finally, it no longer logs an error when an
io.EOFis encountered as that is an expected condition when the client disconnects and is not an actual error.