main: Defer database close. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
main_defers_db_close
branch
2 times, most recently
from
9b46362
to
290ea16
Compare
jholdstock
reviewed
Sep 12, 2023
This defers the database close once opened to ensure it is always properly closed on all error paths. It also adds a defer for the overall shutdown complete message and updates the hub shutdown complete message to indicate it's referring to the hub.
davecgh
force-pushed
the
main_defers_db_close
branch
from
290ea16
to
805ff82
Compare
jholdstock
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #352.
This defers the database close once opened to ensure it is always properly closed on all error paths.