multi: add support for enabling/disabling a dex account #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename AccountDisable to ToggleAccountStatus and allow re-enabling a disabled account. Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
ukane-philemon
changed the title
Signed-off-by: Philemon Ukane <[email protected]>
ukane-philemon
force-pushed
the
disable-server
branch
from
d2b0482
to
5e1dc4d
Compare
buck54321
reviewed
Sep 7, 2024
There was a problem hiding this comment.
utAck just some comments for now. I'm OK with just ignoring the old disabledAccountsBucket from now on. As far as permanent deletion, it has to occur after all bonds are refunded of course, but yeah, do it in a follow up. We'll need this PR or a minimal version of this PR to go on top of release-v1.0 branch too.
Signed-off-by: Philemon Ukane <[email protected]>
buck54321
requested changes
Sep 20, 2024
Signed-off-by: Philemon Ukane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2943
This PR introduces a new behaviour for disabled dex accounts. The account is no longer deleted and will be loaded into memory when core is initialized as an inactive dexConnection to facilitate active bond refunds(if any) every bond rotation. Users can now disable an account with active unspent bonds if they wish to.
Screen.Recording.2024-09-04.at.10.07.53.AM.mov
disabledAccountsBucketwas removed. This means previously disabled accounts are lost. If we intend to allow users to re-enable a previously disabled account without having to add it again, I would restoredisabledAccountsBucketand allow for backward compatibility.As a follow up, I'll implement an endpoint to support deleting a dex server from the db. @buck54321 what do you think?