mm: Add BotProblems to BotStatus #2808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
force-pushed
the
botProblems
branch
2 times, most recently
from
16239b3
to
4bcdffe
Compare
buck54321
requested changes
Jun 21, 2024
JoeGruffins
approved these changes
Jun 27, 2024
client/mm/mm.go
Outdated
Comment on lines
252
to
263
| // DeterminePlacementsErr is true if there was an unidentified error when | ||
| // attempting to determine the rates at which to place orders. | ||
| DeterminePlacementsErr error `json:"determinePlacementsErr"` | ||
| // PlaceBuyOrdersErr is true if there was an unidentified error while | ||
| // placing buy orders. | ||
| PlaceBuyOrdersErr error `json:"placeBuyOrdersErr"` | ||
| // PlaceBuyOrdersErr is true if there was an unidentified error while | ||
| // placing sell orders. | ||
| PlaceSellOrdersErr error `json:"placeSellOrdersErr"` |
There was a problem hiding this comment.
Lash three are type error but description says "is true"
| problems.AccountSuspended = false | ||
| problems.NoOracleAvailable = false | ||
| problems.EmptyMarket = false | ||
| } |
There was a problem hiding this comment.
Missing problems.CEXOrderbookUnsynced
|
Unsure if related to these changes but will see a lot of errors running on simnet with a bot: The one below this may be fixed in #2843 Can be fixed later. |
This PR adds a BotProblems struct to BotStatus that reports issues that bots are facing. Some problems such as wallet sync and connectivity are checked preemptively while others are reported when errors arise during determining what orders to place and when actually placing them. The preemptive checks are especially important for the Arb bot which additionally confirms that the trading limits allow for an additional trade. Balance deficiencies are also reported in BotProblems.
martonp
force-pushed
the
botProblems
branch
from
9e510a4
to
95aaade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
BotProblemsstruct toBotStatusthat reports issues that bots are facing. Some problems such as wallet sync and connectivity are checked preemptively while others are reported when errors arise during determining what orders to place and when actually placing them. The preemptive checks are especially important for the Arb bot which additionally confirms that the trading limits allow for an additional trade. Balance deficiencies are also reported inBotProblems.