Circumvent insecure secrets listing #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mowoe Thanks, it seems like a valid solution for a workaround. I will review the PR till the end of the day. Could you please sign your commits using the |
mowoe
force-pushed
the
feature/circumvent-insecure-secrets-listing
branch
from
9885736
to
543976f
Compare
Signed-off-by: Moritz Woermann <[email protected]>
Signed-off-by: Moritz Woermann <[email protected]>
… not the case Signed-off-by: Moritz Woermann <[email protected]>
Co-authored-by: Stephan Krull <[email protected]> Signed-off-by: Moritz Wörmann <[email protected]> Signed-off-by: Moritz Woermann <[email protected]>
Co-authored-by: Stephan Krull <[email protected]> Signed-off-by: Moritz Wörmann <[email protected]> Signed-off-by: Moritz Woermann <[email protected]>
mowoe
force-pushed
the
feature/circumvent-insecure-secrets-listing
branch
from
543976f
to
b9608e1
Compare
|
Thanks @nabokihms for the lightning fast response, i signed the commits now. |
nabokihms
requested changes
Feb 19, 2024
Signed-off-by: Moritz Woermann <[email protected]>
mowoe
force-pushed
the
feature/circumvent-insecure-secrets-listing
branch
from
0a1c587
to
aef782b
Compare
nabokihms
requested changes
Feb 26, 2024
|
@mowoe don't mind chart testing, they should fail 🙂 |
Co-authored-by: Maksim Nabokikh <[email protected]> Signed-off-by: Moritz Wörmann <[email protected]> Signed-off-by: Moritz Woermann <[email protected]>
Co-authored-by: Maksim Nabokikh <[email protected]> Signed-off-by: Moritz Wörmann <[email protected]> Signed-off-by: Moritz Woermann <[email protected]>
…exporter into feature/circumvent-insecure-secrets-listing Signed-off-by: Moritz Woermann <[email protected]>
Signed-off-by: Moritz Woermann <[email protected]>
mowoe
force-pushed
the
feature/circumvent-insecure-secrets-listing
branch
from
fef7066
to
f4fa9a3
Compare
Signed-off-by: Moritz Woermann <[email protected]>
|
@nabokihms should finally be okay now, can you approve the CI runs again? 🙂 |
|
@mowoe thanks for the contribution. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue described in #7 which allows the exporter to run when no secret access is present in the ClusterRole.
It just prints a warning about this, but continues to work other than that.