Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze devise-i18n to 1.11.0 #11709

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Freeze devise-i18n to 1.11.0 #11709

merged 1 commit into from
Oct 3, 2023

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Lock devise-i18n to 1.11.0 to avoid helper loading issue. When running performance metrics pipeline usin devise-i18n v 1.11.1, we will get the error from below screenshot. It was first revealed in #11707 , while running pipeline https://github.com/decidim/decidim/actions/runs/6388830214/job/17339831244

image

📌 Related Issues

Link your PR to an issue

Testing

Make sure the pipeline is green.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Oct 3, 2023
@alecslupu alecslupu marked this pull request as ready for review October 3, 2023 09:13
@alecslupu alecslupu requested a review from a team October 3, 2023 09:13
@alecslupu alecslupu added this to the 0.28.0 milestone Oct 3, 2023
andreslucena
andreslucena approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this same error in nightly, and tried this branch and seems like it's all good 👍🏽

@andreslucena andreslucena added the dependencies Pull requests that update a dependency file or issues that talk about updating dependencies label Oct 3, 2023
@andreslucena andreslucena merged commit 2598798 into develop Oct 3, 2023
93 checks passed
@andreslucena andreslucena deleted the chore/patch-devise-i18n branch October 3, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Maintainers' backlog
Archived in project
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alecslupu @andreslucena