Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and document the verifier #311

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Fix and document the verifier #311

merged 9 commits into from
Jan 11, 2024

Conversation

microstudi
Copy link
Contributor

@microstudi microstudi commented Dec 12, 2023

Fixes the verifier for ballots or election logs (a tar file).

  • Verifying a single ballot requires python and the library electionguard to be installed.
  • Verifying a tar election file requires java and to compile a JAR file.

I've added instructions in the README file to documentat all of this, is not ideal but it can save you a lot of time.

fixes #231
supersedes #192
requires #310 to be merged to fix the rubocop issues

image

@microstudi microstudi marked this pull request as ready for review December 13, 2023 18:35
@microstudi microstudi changed the title fix & documentate verifier fix & documentat verifier Dec 13, 2023
@microstudi microstudi changed the title fix & documentat verifier fix & document the verifier Dec 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be58cb5) 69.57% compared to head (fb1b4f4) 69.57%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #311   +/-   ##
========================================
  Coverage    69.57%   69.57%           
========================================
  Files           96       96           
  Lines         1630     1630           
========================================
  Hits          1134     1134           
  Misses         496      496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreslucena andreslucena changed the title fix & document the verifier Fix & document the verifier Jan 9, 2024
@andreslucena andreslucena changed the title Fix & document the verifier Fix and document the verifier Jan 9, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the installation instructions. For the moment it seems much better than what we have. There's just a minor detail to fix and we can merge this

verifier/README.md Outdated Show resolved Hide resolved
@andreslucena andreslucena merged commit 46faa76 into develop Jan 11, 2024
9 checks passed
@andreslucena andreslucena deleted the fix_verifier branch January 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verifier undocumented
4 participants