feat: New project events #1874
Merged
feat: New project events #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1emu
approved these changes
Jul 3, 2024
| } | ||
|
|
||
| export async function down(): Promise<void> { | ||
| return |
There was a problem hiding this comment.
shouldn't you remove those event types?
There was a problem hiding this comment.
It's not recommended to do that (check here)
| @@ -209,6 +210,7 @@ export async function finishProposal() { | |||
| BadgesService.giveFinishProposalBadges(proposalsWithOutcome) | |||
| DiscourseService.commentFinishedProposals(proposalsWithOutcome) | |||
| DiscordService.notifyFinishedProposals(proposalsWithOutcome) | |||
| await EventsService.proposalFinished(proposalsWithOutcome) | |||
There was a problem hiding this comment.
I don't think we need to await this
There was a problem hiding this comment.
why not? it's an async method
| @@ -306,6 +306,7 @@ export class ProposalService { | |||
| const project = await ProjectService.getUpdatedProject(proposal.project_id!) | |||
| updatedProposal.project_status = project.status | |||
| NotificationService.projectProposalEnacted(proposal) | |||
| await EventsService.projectEnacted(project) | |||
There was a problem hiding this comment.
it's also an async method 🤔
| @@ -354,6 +359,43 @@ export class EventsService { | |||
| } | |||
| } | |||
|
|
|||
| static async proposalFinished(proposalsWithOutcome: ProposalWithOutcome[]) { | |||
| for (const proposal of proposalsWithOutcome) { | |||
There was a problem hiding this comment.
I'm wondering if we should try catch inside the for... wdyt?
andyesp
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1776