fix: top voters chart #1251
Merged
fix: top voters chart #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
1emu
commented
Sep 7, 2023
1emu
commented
1emu
force-pushed
the
fix/top-voters-chart
branch
from
0d7e0b8
to
d59d834
Compare
andyesp
reviewed
Sep 11, 2023
andyesp
reviewed
Sep 11, 2023
ncomerci
approved these changes
Sep 11, 2023
1emu
added a commit
that referenced
this pull request
Sep 12, 2023
* fix: use Dayjs for TopVoters chart, add more tests for top voters cases * chore: update top voters chart copy * fix: use Dayjs to calculate dates for voting stats * chore: sort top voters by lastVoted in ascending order as secondary criteria * refactor: address pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.