Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upload badge spec to ipfs #1214

Merged
merged 13 commits into from
Aug 29, 2023
Merged

chore: upload badge spec to ipfs #1214

merged 13 commits into from
Aug 29, 2023

Conversation

1emu
Copy link
Collaborator

@1emu 1emu commented Aug 25, 2023

image

@1emu 1emu requested review from andyesp and ncomerci August 25, 2023 21:00
@yemel yemel temporarily deployed to governance-pr-1214 August 25, 2023 21:00 Inactive
src/back/routes/badges.ts Outdated Show resolved Hide resolved
src/back/routes/badges.ts Outdated Show resolved Hide resolved
@@ -112,3 +113,62 @@ export async function getLandOwnerAddresses(): Promise<string[]> {
return []
}
}

const blobToFile = (theBlob: Blob, fileName: string): File => {
const b: any = theBlob
Copy link
Member

@andyesp andyesp Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write this like

return { ...theBlob, name: fileName, lastModifiedDate: new Date() } as File

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it but it didn't work. Also tried as any as File but no luck

@yemel yemel temporarily deployed to governance-pr-1214 August 28, 2023 17:29 Inactive
@yemel yemel temporarily deployed to governance-pr-1214 August 28, 2023 20:04 Inactive
@1emu 1emu force-pushed the chore/upload-badge-spec-to-ipfs branch from d7caabb to e7faa6f Compare August 28, 2023 20:23
@1emu 1emu temporarily deployed to governance-pr-1214 August 28, 2023 20:24 Inactive
src/back/routes/badges.ts Outdated Show resolved Hide resolved
src/clients/Governance.ts Outdated Show resolved Hide resolved
src/clients/Governance.ts Outdated Show resolved Hide resolved
src/back/routes/badges.ts Outdated Show resolved Hide resolved
src/back/routes/badges.ts Outdated Show resolved Hide resolved
src/back/utils/validations.ts Show resolved Hide resolved
@1emu 1emu temporarily deployed to governance-pr-1214 August 29, 2023 18:55 Inactive
@1emu 1emu merged commit 9c909e4 into master Aug 29, 2023
1 check passed
@1emu 1emu deleted the chore/upload-badge-spec-to-ipfs branch August 29, 2023 19:04
1emu added a commit that referenced this pull request Sep 12, 2023
* chore: find top voters (#1201)

* chore: move get top voters to vote service
* refactor: validate on routes and call services instead of models

* feat: upload and mint form WIP

* chore: add date picker for expiration date

* chore: update jest config and resolver to work with nft storage

* chore: upload spec to IPFS

* chore: move constants

* chore: mint WIP

* chore: minor refactor to estimateGas

* fix: set top voters route as POST

* chore: upload and mint badge from debug

* chore: address pr comments, improve responses, log tx hashes

* refactor: validateDebugAddress

* refactor: renames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants