Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use snapshot api key in all snapshot requests #1211

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: use snapshot api key in all snapshot requests #1211

merged 3 commits into from
Aug 28, 2023

Conversation

andyesp
Copy link
Member

@andyesp andyesp commented Aug 25, 2023 •
edited
Loading

Closes #1198

TODO:

  • Use Snapshot API Key in utils.getScores
  • Move getProposalScores call in useProposalOutcome to backend

@yemel yemel temporarily deployed to governance-pr-1211 August 25, 2023 18:05 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1211 August 25, 2023 18:16 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1211 August 28, 2023 17:27 Inactive
1emu
1emu approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@1emu 1emu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@andyesp andyesp merged commit 9913b99 into master Aug 28, 2023
1 check passed
@andyesp andyesp deleted the feat/snapshot-client-with-api-key branch August 28, 2023 18:18
1emu pushed a commit that referenced this pull request Sep 12, 2023
@andyesp @1emu
feat: use snapshot api key in all snapshot requests (#1211)
d18f764 
* feat: move scores calculation to backend

* fix: scores not working on sepolia

* refactor: move getProposalScores to backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1emu 1emu 1emu approved these changes

@ncomerci ncomerci ncomerci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Snapshot integration to comply with new ratelimits
4 participants
@andyesp @1emu @ncomerci @yemel