Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace useClipboardCopy from dcl-gatsby #1051

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

ncomerci
Copy link
Contributor

This closes #1050

@ncomerci ncomerci requested review from 1emu and andyesp June 27, 2023 15:08
@yemel yemel temporarily deployed to governance-pr-1051 June 27, 2023 15:08 Inactive
@yemel yemel temporarily deployed to governance-pr-1051 June 27, 2023 18:34 Inactive
Copy link
Collaborator

@1emu 1emu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some doubts about the naming

 return {
    copiedValue,
    copy,
    clear,
  }

The word copy could also refer to the copied value, so in some contexts it might not be entirely clear
(when we do const { copy } = useClipboardCopy(Time.Second) for example)

I think copyValue could be a slightly better name for the function, but I'm not against leaving it as it is.

@yemel yemel temporarily deployed to governance-pr-1051 June 28, 2023 18:01 Inactive
@andyesp andyesp merged commit 932ef35 into master Jun 28, 2023
@andyesp andyesp deleted the refactor/1050-clipboard-copy branch October 17, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace useClipboardCopy from dcl-gatsby
4 participants