Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace useAsyncTask #1026

Merged
merged 2 commits into from
Jun 16, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import classNames from 'classnames'
import Label from 'decentraland-gatsby/dist/components/Form/Label'
import Paragraph from 'decentraland-gatsby/dist/components/Text/Paragraph'
import useAuthContext from 'decentraland-gatsby/dist/context/Auth/useAuthContext'
import useAsyncTask from 'decentraland-gatsby/dist/hooks/useAsyncTask'
import useFormatMessage from 'decentraland-gatsby/dist/hooks/useFormatMessage'
import { Button } from 'decentraland-ui/dist/components/Button/Button'
import { Close } from 'decentraland-ui/dist/components/Close/Close'
Expand All @@ -14,6 +13,7 @@ import { Modal, ModalProps } from 'decentraland-ui/dist/components/Modal/Modal'
import isEmail from 'validator/lib/isEmail'

import { Decentraland } from '../../../clients/Decentraland'
import useAsyncTask from '../../../hooks/useAsyncTask'
import { ANONYMOUS_USR_SUBSCRIPTION, NEWSLETTER_SUBSCRIPTION_KEY } from '../../Banner/Subscription/SubscriptionBanner'
import CheckCloud from '../../Icon/CheckCloud'
import '../ProposalModal.css'
Expand Down
72 changes: 72 additions & 0 deletions src/hooks/useAsyncTask.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/* eslint-disable react-hooks/exhaustive-deps */
import { DependencyList, useCallback, useEffect, useState } from 'react'

import useTrackContext from 'decentraland-gatsby/dist/context/Track/useTrackContext'

import { ErrorClient } from '../clients/ErrorClient'

type AsyncTaskState<A extends unknown[] = []> = {
loading: boolean
args: A | null
}

export default function useAsyncTask<A extends unknown[] = []>(
callback: (...args: A) => Promise<unknown>,
deps: DependencyList
) {
const [{ loading, args }, setLoading] = useState<AsyncTaskState<A>>({
loading: false,
args: null,
})

const segment = useTrackContext()

useEffect(() => {
if (!loading) {
return
}

if (args === null) {
return
}

let cancelled = false
Promise.resolve()
.then(() => callback(...args))
.then(() => {
if (cancelled) {
return
}

setLoading({ loading: false, args: null })
})
.catch((err) => {
console.error(err)
const errorObj = {
...err,
message: err.message,
stack: err.stack,
}
ErrorClient.report('error', errorObj)
segment('error', errorObj)
ncomerci marked this conversation as resolved.
Show resolved Hide resolved
if (cancelled) {
return
}

setLoading({ loading: false, args: null })
})

return () => {
cancelled = true
}
}, [loading])

const callTask = useCallback(
(...args: A) => {
setLoading({ loading: true, args })
},
[loading, args, ...deps]
)

return [loading, callTask] as const
}
5 changes: 3 additions & 2 deletions src/hooks/useSubscriptions.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
import useAuthContext from 'decentraland-gatsby/dist/context/Auth/useAuthContext'
import useAsyncMemo from 'decentraland-gatsby/dist/hooks/useAsyncMemo'
import useAsyncTasks from 'decentraland-gatsby/dist/hooks/useAsyncTasks'

import { Governance } from '../clients/Governance'

import useAsyncTask from './useAsyncTask'

export default function useSubscriptions() {
const [account] = useAuthContext()
const [subscriptions, subscriptionsState] = useAsyncMemo(() => Governance.get().getUserSubscriptions(), [account], {
callWithTruthyDeps: true,
initialValue: [],
})
const [subscribing, subscribe] = useAsyncTasks(
const [subscribing, subscribe] = useAsyncTask(
async (id: string) => {
if (account && subscriptions) {
if (subscriptions.find((subscription) => subscription.proposal_id === id)) {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/proposal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import NotFound from 'decentraland-gatsby/dist/components/Layout/NotFound'
import Markdown from 'decentraland-gatsby/dist/components/Text/Markdown'
import useAuthContext from 'decentraland-gatsby/dist/context/Auth/useAuthContext'
import useAsyncMemo from 'decentraland-gatsby/dist/hooks/useAsyncMemo'
import useAsyncTask from 'decentraland-gatsby/dist/hooks/useAsyncTask'
import useFormatMessage from 'decentraland-gatsby/dist/hooks/useFormatMessage'
import usePatchState from 'decentraland-gatsby/dist/hooks/usePatchState'
import { navigate } from 'decentraland-gatsby/dist/plugins/intl'
Expand Down Expand Up @@ -53,6 +52,7 @@ import { Survey } from '../entities/SurveyTopic/types'
import { SurveyEncoder } from '../entities/SurveyTopic/utils'
import { isProposalStatusWithUpdates } from '../entities/Updates/utils'
import { SelectedVoteChoice, Vote } from '../entities/Votes/types'
import useAsyncTask from '../hooks/useAsyncTask'
import useBudgetWithContestants from '../hooks/useBudgetWithContestants'
import useIsDAOCommittee from '../hooks/useIsDAOCommittee'
import useIsProposalCoAuthor from '../hooks/useIsProposalCoAuthor'
Expand Down