refactor: extract common type to shared/types

decentraland · Sep 14, 2023 · 0574e3a · 0574e3a
1 parent b1e3150
commit 0574e3a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/src/back/routes/newsletter.ts b/src/back/routes/newsletter.ts
@@ -6,8 +6,8 @@ import fetch from 'isomorphic-fetch'
 import isEmail from 'validator/lib/isEmail'
 
 import { ErrorService } from '../../services/ErrorService'
+import { NewsletterSubscriptionResult } from '../../shared/types/newsletter'
 import { ErrorCategory } from '../../utils/errorCategories'
-import { NewsletterSubscriptionResult } from '../types/newsletter'
 
 export default routes((router) => {
   router.post('/newsletter-subscribe', handleAPI(handleSubscription))

diff --git a/src/clients/Governance.ts b/src/clients/Governance.ts
@@ -4,7 +4,6 @@ import env from 'decentraland-gatsby/dist/utils/env'
 import snakeCase from 'lodash/snakeCase'
 
 import { AirdropOutcome } from '../back/types/AirdropJob'
-import { NewsletterSubscriptionResult } from '../back/types/newsletter'
 import { SpecState } from '../components/Debug/UploadBadgeSpec'
 import { GOVERNANCE_API } from '../constants'
 import { BadgeCreationResult, RevokeOrReinstateResult, UserBadges } from '../entities/Badges/types'
@@ -36,6 +35,7 @@ import { SubscriptionAttributes } from '../entities/Subscription/types'
 import { Topic } from '../entities/SurveyTopic/types'
 import { ProjectHealth, UpdateAttributes, UpdateResponse } from '../entities/Updates/types'
 import { Vote, VotedProposal, Voter } from '../entities/Votes/types'
+import { NewsletterSubscriptionResult } from '../shared/types/newsletter'
 import Time from '../utils/date/Time'
 
 import { TransparencyBudget } from './DclData'

diff --git a/src/components/Modal/NewsletterSubscriptionModal/NewsletterSubscriptionModal.tsx b/src/components/Modal/NewsletterSubscriptionModal/NewsletterSubscriptionModal.tsx
@@ -9,10 +9,10 @@ import { Header } from 'decentraland-ui/dist/components/Header/Header'
 import { Modal, ModalProps } from 'decentraland-ui/dist/components/Modal/Modal'
 import isEmail from 'validator/lib/isEmail'
 
-import { NewsletterSubscriptionResult } from '../../../back/types/newsletter'
 import { Governance } from '../../../clients/Governance'
 import useAsyncTask from '../../../hooks/useAsyncTask'
 import useFormatMessage from '../../../hooks/useFormatMessage'
+import { NewsletterSubscriptionResult } from '../../../shared/types/newsletter'
 import { ANONYMOUS_USR_SUBSCRIPTION, NEWSLETTER_SUBSCRIPTION_KEY } from '../../Banner/Subscription/SubscriptionBanner'
 import Label from '../../Common/Typography/Label'
 import Text from '../../Common/Typography/Text'

diff --git a/src/back/types/newsletter.ts → src/shared/types/newsletter.ts b/src/back/types/newsletter.ts → src/shared/types/newsletter.ts