feat: Add virtual third parties #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10965795567Details
💛 - Coveralls |
…feat/add-virtual-third-parties
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cyaiox
reviewed
Sep 18, 2024
src/Item/Item.service.ts
Outdated
| @@ -11,7 +11,7 @@ import { ItemCuration } from '../Curation/ItemCuration' | |||
| import { Bridge } from '../ethereum/api/Bridge' | |||
| import { collectionAPI } from '../ethereum/api/collection' | |||
| import { peerAPI } from '../ethereum/api/peer' | |||
| import { thirdPartyAPI } from '../ethereum/api/thirdParty' | |||
| // import { thirdPartyAPI } from '../ethereum/api/thirdParty' | |||
There was a problem hiding this comment.
Suggested change
| // import { thirdPartyAPI } from '../ethereum/api/thirdParty' |
cyaiox
reviewed
Sep 18, 2024
src/Item/Item.service.ts
Outdated
| @@ -49,6 +49,7 @@ import { | |||
| isTPItem, | |||
| toDBItem, | |||
| } from './utils' | |||
| import { ThirdPartyService } from '../ThirdParty/ThirdParty.service' | |||
There was a problem hiding this comment.
could you move this import above?
cyaiox
reviewed
Sep 18, 2024
| operation: 'UPDATE', | ||
| level: 'ROW', | ||
| function: update_updated_at_column_function_name, | ||
| condition: 'OLD.* IS DISTINCT FROM NEW.*', |
There was a problem hiding this comment.
shouldn't the updated_at field be updated with each update? or should it meet a specific condition?
There was a problem hiding this comment.
The updated_at column will get updated only if any column in the row gets updated to something new. If it doesn't, we'll be saving a write operation by not updating the updated_at.
cyaiox
reviewed
Sep 18, 2024
src/ThirdParty/ThirdParty.service.ts
Outdated
| : ([] as ThirdParty[]), | ||
| ]) | ||
| const graphThirdParties = fragments.map(toThirdParty) | ||
| console.log({ graphThirdParties, virtualThirdParties }) |
There was a problem hiding this comment.
Suggested change
| console.log({ graphThirdParties, virtualThirdParties }) |
cyaiox
approved these changes
Sep 18, 2024
…feat/add-virtual-third-parties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of using creating virtual third parties. That is, third parties created with the purpose of being temporary third parties until the registration is done on chain.