Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lowercase address and return completion on creation #771

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: Lowercase address and return completion on creation #771

merged 2 commits into from
Sep 5, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR does two things:

  • Returns the is_mapping_complete status when creating a new collection.
  • Lowercases the linked_contract_address and linked_contract_network when upserting a new collection.

@LautaroPetaccio LautaroPetaccio merged commit ce2015c into master Sep 5, 2024
4 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/lowercase-address-and-return-completion-on-creation branch September 5, 2024 18:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10726368266

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 71.416%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Collection/Collection.model.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10672271516: 0.1%
Covered Lines: 3096
Relevant Lines: 4187
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyaiox cyaiox cyaiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LautaroPetaccio @coveralls @cyaiox