Garther and expose OpenSSL and GnuTLS versions in local facts #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypid
force-pushed
the
expose/crypto_lib_versions
branch
from
0acf2a7
to
bd6001b
Compare
ypid
force-pushed
the
expose/crypto_lib_versions
branch
from
bd6001b
to
f004f0f
Compare
drybjed
reviewed
Sep 26, 2016
| @@ -43,6 +43,8 @@ | |||
| run_once: True | |||
| always_run: True | |||
|
|
|||
| # TODO: When there is any need to change this task, consider refactoring and | |||
| # using the versions provided in local facts. | |||
There was a problem hiding this comment.
Nope, this would be wrong. Local facts are based on information from remote hosts; Ansible Controller does not have any facts available, and we cannot really do anything about this (unless Ansible Controller is managed by DebOps, but that isn't a given). I would remove this comment to not mislead future contributors.
There was a problem hiding this comment.
Good catch. I missed that. Fixed.
ypid
added a commit
to ypid/ansible-pki
that referenced
this pull request
Sep 26, 2016
drybjed
reviewed
Sep 26, 2016
| @@ -31,6 +31,8 @@ Added | |||
|
|
|||
| - Added :envvar:`pki_system_ca_certificates_download_all_hosts_force`. [ypid_] | |||
|
|
|||
| - Garther and expose OpenSSL and GnuTLS versions in Ansible local facts. [ypid_] | |||
There was a problem hiding this comment.
History rewritten, thanks. I guess I need to find a way to let Vim figure out the actual language of the current section because I currently have spelllang set to en and de.
ypid
force-pushed
the
expose/crypto_lib_versions
branch
from
5d20987
to
faa9f36
Compare
drybjed
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.