Improving ACME-related docs #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,6 +153,33 @@ configuration active, it will check for validity of the signed certificate, and | |||
| about a month before the expiration date it will try to renew the certificate | |||
| automatically. | |||
|
|
|||
| I want a certifcate for subdomains but domain | |||
ypid
added a commit
to ypid/ansible-pki
that referenced
this pull request
Sep 6, 2016
* Remove "I want a" from title :) * The ACME severs is unspecific. * `pki_acme` is unrelated to this section. * Comments after YAML variables might case problems in certain YAML modes and should thus be avoided. * Use the more specific term "apex domain" as already suggested by @drybjed in: debops#82 (comment) Related to: debops#82 Wanted confirmation from: @ser, @drybjed
|
Sounds good to me, although I would revise the note about the realm name as commented. |
ypid
added a commit
to ypid/ansible-pki
that referenced
this pull request
Sep 12, 2016
* Remove "I want a" from title :) * The ACME severs is unspecific. * `pki_acme` is unrelated to this section. * Comments after YAML variables might case problems in certain YAML modes and should thus be avoided. * Use the more specific term "apex domain" as already suggested by @drybjed in: debops#82 (comment) Related to: debops#82 Wanted confirmation from: @ser, @drybjed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.