Added many cluster methods & improved testing #244
Conversation
atais
force-pushed
the
cluster-methods
branch
5 times, most recently
from
58a7480
to
74bbf72
Compare
| val commands = makeSortArgs(key, limit, desc, alpha, by, get) ::: List("STORE", storeAt) | ||
| send("SORT", commands)(asLong) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why is sort part of SetOperations ?
There was a problem hiding this comment.
Well you are right it should be some other part of api. Which one would you recommend?
There was a problem hiding this comment.
I think BaseOperations will be better ..
| @@ -47,6 +53,22 @@ trait RedisClusterOps extends AutoCloseable { | |||
| nodeForKey(key).withClient(body(_)) | |||
| } | |||
|
|
|||
| // todo: need Cats Semigroup instance for T to combine, add Cats? | |||
| // https://typelevel.org/cats/typeclasses/semigroup.html | |||
There was a problem hiding this comment.
One of the targets in this library was to keep it free of any dependencies. We could add cats but then I would design the library in a different way using cats-effects to model all effects ..
There was a problem hiding this comment.
Sure. It is not a big deal at the moment but since most of the api is based on Option[A] it's difficult to model cluster api with Iterable[A] result to fit it.
To be honest I don't know what is best now :) I can delete the comment, however it will probably be a topic for further discussion at some point anyway
There was a problem hiding this comment.
i just left todo with a note, i hope its fine.
atais
force-pushed
the
cluster-methods
branch
6 times, most recently
from
fb912e2
to
1d1a48d
Compare
|
I went carefully commit by commit to reduce changes. I reverted changes for |
atais
force-pushed
the
cluster-methods
branch
3 times, most recently
from
bcf0c08
to
ba87939
Compare
|
I have removed breaking changes so I could put them all soon in another commit See the travis output here https://github.com/atais/scala-redis/commits/cluster-methods |
atais
changed the title
Hi again 😄
please merge after #246
Work in progress for tickets:
and continuation of #243
Added:
zscanmentioned IllegalArgumentException: hostname can't be null #216