Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overview page for code gallery #15

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

jpthiele
Copy link
Contributor

As discussed in #7 the old overview website has not yet been ported.

Since @tjhei raised the valid point that the 'how to contribute' part should rather live in the code-gallery repo
I left that part out for now.

Copy link
Member

@tamiko tamiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpthiele Something went wrong for me. Instead of showing a radio button I see the following blurbb on the page:

[:octicons-image-16: Codes](https://dealii.org/developer/doxygen/deal.II/CodeGallery.html){ .md-button .md-button--primary .center }<br> See the list of programs that are part of the code gallery. { .card } [:octicons-download-16: Download](#downloading-the-code-gallery){ .md-button .md-button--primary .center }<br> Downloading the programs of the code gallery is easy. { .card } [:fontawesome-solid-paper-plane: Contribute](https://github.com/dealii/code-gallery){ .md-button .md-button--primary .center }<br> Contribute your own codes as a starting point for others. { .card } 

Also, the menu item for the code gallery points to the doxygen documentation instead of the new code_gallery.md. We need to fix that link as well: (in mkdocs.yml)

   42     - Code Gallery: https://dealii.org/developer/doxygen/deal.II/CodeGallery.html

@jpthiele
Copy link
Contributor Author

@jpthiele Something went wrong for me. Instead of showing a radio button I see the following blurbb on the page:

[:octicons-image-16: Codes](https://dealii.org/developer/doxygen/deal.II/CodeGallery.html){ .md-button .md-button--primary .center }<br> See the list of programs that are part of the code gallery. { .card } [:octicons-download-16: Download](#downloading-the-code-gallery){ .md-button .md-button--primary .center }<br> Downloading the programs of the code gallery is easy. { .card } [:fontawesome-solid-paper-plane: Contribute](https://github.com/dealii/code-gallery){ .md-button .md-button--primary .center }<br> Contribute your own codes as a starting point for others. { .card } 

The <div> was on the same indentation level as the list, which lead to it not being rendered properly

Also, the menu item for the code gallery points to the doxygen documentation instead of the new code_gallery.md. We need to fix that link as well: (in mkdocs.yml)

   42     - Code Gallery: https://dealii.org/developer/doxygen/deal.II/CodeGallery.html

Done.

For some reason I was unable to force push a squashed commit, so it's two for now.

@tamiko tamiko merged commit f51c97a into dealii:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants