Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/get security group by name #609

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Conversation

dweinholz
Copy link
Contributor

Try to fulfill the following points before the Pull Request is merged:

  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • If the PR is merged in the master then a release should be be made.
  • If the new code is readable, if not it should be well commented

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.
  • If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

@dweinholz dweinholz requested a review from vktrrdk October 9, 2024 10:57
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
simple_vm_client
   VirtualMachineHandler.py1911414 93%
   __init__.py10100% 
   test_virtualmachinehandler.py2970100% 
simple_vm_client/benchmark
   __init__.py00100% 
   test_service.py523636 31%
simple_vm_client/bibigrid_connector
   __init__.py00100% 
   bibigrid_connector.py11855 96%
   test_bibigrid_connector.py1730100% 
simple_vm_client/forc_connector
   __init__.py00100% 
   forc_connector.py25544 98%
simple_vm_client/forc_connector/playbook
   __init__.py00100% 
   playbook.py1900100% 
   test_playbook.py3800100% 
simple_vm_client/forc_connector/template
   __init__.py00100% 
   template.py19511 99%
simple_vm_client/metadata_connector
   metadata_connector.py887171 19%
simple_vm_client/openstack_connector
   __init__.py00100% 
   openstack_connector.py907117117 87%
simple_vm_client/util
   __init__.py00100% 
   state_enums.py690100% 
   test_thrift_converter.py1700100% 
   thrift_converter.py771313 83%
TOTAL316326192% 

Tests Skipped Failures Errors Time
299 0 💤 0 ❌ 0 🔥 4.607s ⏱️

@vktrrdk
Copy link
Member

vktrrdk commented Oct 9, 2024

the client is logging the following:

implevm-client        | 2024-10-09 14:53:27 - [INFO] - [/code/simple_vm_client/openstack_connector/openstack_connector.py:get_security_group_id_by_name:1110] - Get Security Group ID by name: bibigridsg-u5h7ezy8tg6ogye
simplevm-client        | INFO:simple_vm_client.openstack_connector.openstack_connector:Get Security Group ID by name: bibigridsg-u5h7ezy8tg6ogye
simplevm-client        | ERROR:root:Unexpected exception in handler
simplevm-client        | Traceback (most recent call last):
simplevm-client        |   File "/code/simple_vm_client/VirtualMachineService.py", line 5270, in process_get_security_group_id_by_name
simplevm-client        |     result.success = self._handler.get_security_group_id_by_name(args.name)
simplevm-client        |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
simplevm-client        |   File "/code/simple_vm_client/VirtualMachineHandler.py", line 483, in get_security_group_id_by_name
simplevm-client        |     return self.openstack_connector.get_security_group_id_by_name(
simplevm-client        |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
simplevm-client        |   File "/code/simple_vm_client/openstack_connector/openstack_connector.py", line 1111, in get_security_group_id_by_name
simplevm-client        |     sec = self.openstack_connection.get_security_group(
simplevm-client        |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
simplevm-client        | TypeError: NetworkCommonCloudMixin.get_security_group() got an unexpected keyword argument 'ignore_missing'
...

@vktrrdk vktrrdk merged commit 6843abc into dev Oct 10, 2024
2 checks passed
@dweinholz dweinholz deleted the feat/get_security_group_by_name branch October 10, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants