forked from nhibernate/nhibernate-core
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nhibernateGH-3530: Firebird incorrectly uses the current culture to c…
…onvert dates stores as strings. Address this issue by adding a FirebirdDbDataReader.
- Loading branch information
David Ellingsworth
authored and
David Ellingsworth
committed
Jun 11, 2024
1 parent
ec49d5f
commit 4b010ce
Showing
3 changed files
with
76 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Data.Common; | ||
using System.Globalization; | ||
using System.Linq; | ||
using System.Text; | ||
using System.Threading.Tasks; | ||
using NHibernate.Id.Insert; | ||
|
||
namespace NHibernate.AdoNet | ||
{ | ||
public class FirebirdDbDataReader : DbDataReaderWrapper | ||
{ | ||
public FirebirdDbDataReader(DbDataReader reader) : base(reader) { } | ||
|
||
public override DateTime GetDateTime(int ordinal) | ||
{ | ||
var value = DataReader[ordinal]; | ||
|
||
return value switch | ||
{ | ||
string s => DateTime.Parse(s, CultureInfo.InvariantCulture), | ||
_ => (DateTime) value | ||
}; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
//------------------------------------------------------------------------------ | ||
// <auto-generated> | ||
// This code was generated by AsyncGenerator. | ||
// | ||
// Changes to this file may cause incorrect behavior and will be lost if | ||
// the code is regenerated. | ||
// </auto-generated> | ||
//------------------------------------------------------------------------------ | ||
|
||
|
||
using System; | ||
using System.Collections.Generic; | ||
using System.Data; | ||
using System.Data.Common; | ||
using System.Linq; | ||
using System.Reflection; | ||
using System.Text.RegularExpressions; | ||
using NHibernate.AdoNet; | ||
using NHibernate.Dialect; | ||
using NHibernate.SqlCommand; | ||
using NHibernate.SqlTypes; | ||
using NHibernate.Util; | ||
using Environment = NHibernate.Cfg.Environment; | ||
|
||
namespace NHibernate.Driver | ||
{ | ||
using System.Threading.Tasks; | ||
using System.Threading; | ||
public partial class FirebirdClientDriver : ReflectionBasedDriver | ||
{ | ||
|
||
public override async Task<DbDataReader> ExecuteReaderAsync(DbCommand command, CancellationToken cancellationToken) | ||
{ | ||
cancellationToken.ThrowIfCancellationRequested(); | ||
var reader = await (command.ExecuteReaderAsync(cancellationToken)).ConfigureAwait(false); | ||
|
||
return new FirebirdDbDataReader(reader); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters