-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat ref #223: fixes the error installing sqlsrv #224
base: master
Are you sure you want to change the base?
feat ref #223: fixes the error installing sqlsrv #224
Conversation
* uses odbc version 2.3.7 * parameterizes PHP version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drupal-daffie please review and manually test this and see if you approve. Assuming you're still familiar with this setup.
I haven't manually tested, but hope @drupal-daffie will take a look |
Actually, what I'd love to have you do is turn this into a ddev-get add-on and then maintain it, so we wouldn't find out things like this by accident. https://ddev.readthedocs.io/en/latest/users/extend/additional-services/#creating-an-additional-service-for-ddev-get Would you consider doing that? |
It sounds good. I'm going to read the add-on documentation and try do create the new add-on. |
@rfay I created this repo for the ddev add-on https://github.com/robertoperuzzo/ddev-sqlsrv |
I have to fix the README and the tests. |
Awesome! You'll probably want to change this PR to a "Go to the maintained add-on instead" notice. |
Let's get this in and please just add a reference to your maintained add-on. Thanks so much! |
I'm sorry but I didn't understand what "add a reference to your maintained add-on" means. |
Just update ddev-contrib here to point to ddev/ddev-sqlsrv and point out that the existing recipe here isn't the authoritative one any more. |
I have not test the code, but all the changes look good to me. |
Fixes issue #223:
The New Solution/Problem/Issue/Bug:
Using the previous Dockerfile I get the following error
It seems something related to version 2.3.11 of unixodbc.
How this PR Solves The Problem:
Forcing the unixodbc version 2.3.7
Manual Testing Instructions:
Dockerfile
in.ddev/web-build/
ddev php --info | grep pdo_sqlsrv
You should get
Related Issue Link(s):