Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable querying cumulative metrics with agg_time_dimension #999

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Enable querying cumulative metrics with agg_time_dimension #999

merged 13 commits into from
Jan 31, 2024

Commits on Jan 26, 2024

  1. Add time_dimension_spec_for_join to JoinOverTimeRangeNode

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    aeaa674 View commit details
    Browse the repository at this point in the history

  2. Update dataflow plan to allow agg_time_dim in place of metric time fo… 

    …r cumulative metrics
    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a02b8d8 View commit details
    Browse the repository at this point in the history

  3. Update dataflow to sql to use specified time dimension for join

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    90743da View commit details
    Browse the repository at this point in the history

  4. Simplify / clarify code in dataflow_to_sql

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    945c5bf View commit details
    Browse the repository at this point in the history

  5. Update validations to allow agg_time_dimension for cumulative metrics

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4c9669f View commit details
    Browse the repository at this point in the history

  6. Use appropriate primary entity name in test YAML

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fc78da5 View commit details
    Browse the repository at this point in the history

  7. Integratoin test

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    98597ef View commit details
    Browse the repository at this point in the history

  8. Add query rendering tests

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2e3ef5b View commit details
    Browse the repository at this point in the history

  9. Update snapshots

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e6635a2 View commit details
    Browse the repository at this point in the history

  10. Changelog

    @courtneyholcomb
    courtneyholcomb committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a28e227 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Raise appropriate error if time constraint is used without metric_time

    @courtneyholcomb
    courtneyholcomb committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f8bae3a View commit details
    Browse the repository at this point in the history

  2. Fix newly broken test

    @courtneyholcomb
    courtneyholcomb committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b8f5c9b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Update snapshots

    @courtneyholcomb
    courtneyholcomb committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3f0beec View commit details
    Browse the repository at this point in the history