Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling unit tests #10831

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support disabling unit tests #10831

wants to merge 2 commits into from

Conversation

tsturge
Copy link

@tsturge tsturge commented Oct 7, 2024

Support config: disabled for unit tests. (#9109)

Also, when a model is disabled, disable the corresponding unit tests automatically. (#10540)

Problem

config:
enabled: false

Solution

Check for the config: enabled variable while parsing the unit test. If it is set to false, mark the unit test as disabled.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

Also, when a model is disabled, disable the corresponding unit tests automatically. (#10540)
@tsturge tsturge requested a review from a team as a code owner October 7, 2024 19:09
Copy link

cla-bot bot commented Oct 7, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @tsturge

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (fc83f5e) to head (e7f4684).

❗ There is a different number of reports uploaded between BASE (fc83f5e) and HEAD (e7f4684). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (fc83f5e) HEAD (e7f4684)
unit 2 1
integration 10 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10831      +/-   ##
==========================================
- Coverage   89.14%   82.55%   -6.60%     
==========================================
  Files         183      183              
  Lines       23402    23414      +12     
==========================================
- Hits        20862    19329    -1533     
- Misses       2540     4085    +1545     
Flag Coverage Δ
integration 77.97% <57.14%> (-8.39%) ⬇️
unit 62.14% <42.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.14% <42.85%> (+0.02%) ⬆️
Integration Tests 77.97% <57.14%> (-8.39%) ⬇️

Copy link

cla-bot bot commented Oct 7, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @tsturge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant