-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disabling unit tests #10831
base: main
Are you sure you want to change the base?
Support disabling unit tests #10831
Conversation
Also, when a model is disabled, disable the corresponding unit tests automatically. (#10540)
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @tsturge |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10831 +/- ##
==========================================
- Coverage 89.14% 82.55% -6.60%
==========================================
Files 183 183
Lines 23402 23414 +12
==========================================
- Hits 20862 19329 -1533
- Misses 2540 4085 +1545
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @tsturge |
Support config: disabled for unit tests. (#9109)
Also, when a model is disabled, disable the corresponding unit tests automatically. (#10540)
Problem
config:
enabled: false
Solution
Check for the config: enabled variable while parsing the unit test. If it is set to false, mark the unit test as disabled.
Checklist