Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.1.latest] Fix #9907: Add retry to tox to reduce flaky tests due to network failures #10179

Merged
merged 2 commits into from
May 21, 2024
Merged

[Backport 1.1.latest] Fix #9907: Add retry to tox to reduce flaky tests due to network failures #10179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a5e7e9
[Backport 1.1.latest] Fix #9907: Add retry to tox to reduce flaky tes…
aranke May 14, 2024
ddead6f
Update main.yml
aranke May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ jobs:
pip install tox
tox --version

- name: Run tox
run: tox
- name: Run unit tests
uses: nick-fields/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: tox -e unit

- name: Get current date
if: always()
Expand Down Expand Up @@ -158,8 +162,12 @@ jobs:
pip install tox
tox --version

- name: Run tests
run: tox
- name: Run integration tests
uses: nick-fields/retry@v3
with:
timeout_minutes: 30
max_attempts: 3
command: tox

- name: Get current date
if: always()
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/structured-logging-schema-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ jobs:
# integration tests generate a ton of logs in different files. the next step will find them all.
# we actually care if these pass, because the normal test run doesn't usually include many json log outputs
- name: Run integration tests
run: tox -e integration -- -nauto
uses: nick-fields/retry@v3
with:
timeout_minutes: 30
max_attempts: 3
command: tox -e integration -- -nauto

# apply our schema tests to every log event from the previous step
# skips any output that isn't valid json
Expand Down
Loading