Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring Python >=3.8 enables walrus operator #852

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

dbeatty10
Copy link
Contributor

resolves #849
docs N/A

Problem & Solution

The problem and solution are explained clearly in #849

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc)

@dbeatty10 dbeatty10 requested a review from a team as a code owner August 3, 2023 16:31
@cla-bot cla-bot bot added the cla:yes label Aug 3, 2023
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Aug 3, 2023
@dbeatty10
Copy link
Contributor Author

Could we backport this as well?

@mikealfare
Copy link
Contributor

Could we backport this as well?

Agreed. We need to backport it all the way since py37 is EOL and no longer supported.

@mikealfare
Copy link
Contributor

@dbeatty10, do you mind updating the comment at the top of setup.py as well? It doesn't do anything, but if we're updating this, we might as well do both.

@dbeatty10
Copy link
Contributor Author

@dbeatty10, do you mind updating the comment at the top of setup.py as well? It doesn't do anything, but if we're updating this, we might as well do both.

I updated the comment to be evergreen:

- # require python 3.7 or newer
+ # require a supported version of Python

@mikealfare mikealfare merged commit 4368ef4 into main Aug 3, 2023
13 checks passed
@mikealfare mikealfare deleted the dbeatty/fix-849 branch August 3, 2023 17:01
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-852-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4368ef497d05e6069b4b45ea100d4258536e9521
# Push it to GitHub
git push --set-upstream origin backport-852-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-852-to-1.0.latest.

github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)
mikealfare pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)

Co-authored-by: Doug Beatty <[email protected]>
mikealfare pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)

Co-authored-by: Doug Beatty <[email protected]>
mikealfare pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)

Co-authored-by: Doug Beatty <[email protected]>
mikealfare pushed a commit that referenced this pull request Aug 3, 2023
* Requiring Python >=3.8 enables walrus operator

* Update comment to be evergreen

---------

Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4368ef4)

Co-authored-by: Doug Beatty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-757] SyntaxError: walrus operator in Python 3.7
2 participants