-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requiring Python >=3.8 enables walrus operator #852
Conversation
Could we backport this as well? |
Agreed. We need to backport it all the way since py37 is EOL and no longer supported. |
@dbeatty10, do you mind updating the comment at the top of |
I updated the comment to be evergreen: - # require python 3.7 or newer
+ # require a supported version of Python |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-852-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4368ef497d05e6069b4b45ea100d4258536e9521
# Push it to GitHub
git push --set-upstream origin backport-852-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest Then, create a pull request where the |
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4)
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4)
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4)
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4)
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4)
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4)
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4) Co-authored-by: Doug Beatty <[email protected]>
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4) Co-authored-by: Doug Beatty <[email protected]>
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4) Co-authored-by: Doug Beatty <[email protected]>
* Requiring Python >=3.8 enables walrus operator * Update comment to be evergreen --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 4368ef4) Co-authored-by: Doug Beatty <[email protected]>
resolves #849
docs N/A
Problem & Solution
The problem and solution are explained clearly in #849
Checklist