Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add quota project option #1345

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jcarpenter12
Copy link

@jcarpenter12 jcarpenter12 commented Sep 11, 2024

resolves #1343
resolves #1344
resolves #1347

Docs PR dbt-labs/docs.getdbt.com#6054

Problem

Currently it is not possible to set a quota project in the profiles.yml configuration for BigQuery. This means that the quota project defaults to the quota project of the credentials. This can cause issues if using an account to auth that does not have the BQ API enabled (see bug here #1347 ). It also means that users can not run their models under a specific quota project if they want to.

Solution

Add an optional quota_project param in the profiles.yml that will allow a user to set a quota project if they want to. If they do not set it the behaviour will not change. The only override being applied is a config_option for the quota project that defaults to None anyway.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 11, 2024
@colin-rogers-dbt colin-rogers-dbt added user docs [docs.getdbt.com] Needs better documentation community This PR is from a community member labels Sep 25, 2024
@jcarpenter12
Copy link
Author

@colin-rogers-dbt thank you for taking a look at this, do you know what the next steps with might look like? Am i right in thinking that if this change is merged it will be in the next release? Do you happen to know when that release is likely to be?
The reason I ask is that this change would resolve a bug in our CI pipelines (service accounts are defined in a project that does not have BQ API enabled, so they fail), so currently I am holding off making a workaround if this feature is in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
3 participants