Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding column schema attributes #1329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Adding column schema attributes #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dbt/adapters/bigquery/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,17 @@ class BigQueryColumn(Column):
}
fields: List[Self] # type: ignore
mode: str
description: str
default_value_expression: str

def __init__(
self,
column: str,
dtype: str,
fields: Optional[Iterable[SchemaField]] = None,
mode: str = "NULLABLE",
description: Optional[Union[SchemaField]] = "",
default_value_expression: Optional[Union[SchemaField]] = "",
) -> None:
super().__init__(column, dtype)

Expand All @@ -34,6 +38,8 @@ def __init__(

self.fields = self.wrap_subfields(fields)
self.mode = mode
self.description = description
self.default_value_expression = default_value_expression

@classmethod
def wrap_subfields(cls: Type[Self], fields: Iterable[SchemaField]) -> List[Self]:
Expand Down Expand Up @@ -115,7 +121,7 @@ def can_expand_to(self: Self, other_column: Self) -> bool:
return self.is_string() and other_column.is_string()

def __repr__(self) -> str:
return "<BigQueryColumn {} ({}, {})>".format(self.name, self.data_type, self.mode)
return "<BigQueryColumn {} ({}, {}, {}, {})>".format(self.name, self.data_type, self.mode, self.description, self.default_value_expression)

def column_to_bq_schema(self) -> SchemaField:
"""Convert a column to a bigquery schema object."""
Expand Down
2 changes: 1 addition & 1 deletion dbt/adapters/bigquery/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def _get_dbt_columns_from_bq_table(self, table) -> List[BigQueryColumn]:
for col in table.schema:
# BigQuery returns type labels that are not valid type specifiers
dtype = self.Column.translate_type(col.field_type)
column = self.Column(col.name, dtype, col.fields, col.mode)
column = self.Column(col.name, dtype, col.fields, col.mode, col.description, col.default_value_expression)
columns.append(column)

return columns
Expand Down