Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing test_cancel in 3.12 #1322

Merged
merged 14 commits into from
Aug 21, 2024
Merged

fix failing test_cancel in 3.12 #1322

merged 14 commits into from
Aug 21, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Aug 20, 2024 •
edited
Loading

  • Specify env in test_cancel subprocess call

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Aug 20, 2024
@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review August 20, 2024 22:01
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner August 20, 2024 22:01
VersusFacit
VersusFacit approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You've given me homework on the difference between . and -e. in Python package management's ever deepening world of package management

@colin-rogers-dbt colin-rogers-dbt merged commit 01cb679 into main Aug 21, 2024
20 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the fixCancelTestIn312 branch August 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @VersusFacit