Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on dbt-core legacy logger #1233

Merged
merged 5 commits into from
May 13, 2024
Merged

remove dependency on dbt-core legacy logger #1233

merged 5 commits into from
May 13, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

  • remove broken import

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review May 13, 2024 20:28
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner May 13, 2024 20:28
@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label May 13, 2024
@mikealfare
Copy link
Contributor

Failures are from colliding python integrations tests, which are unrelated to these changes.

@mikealfare mikealfare merged commit d148cc3 into main May 13, 2024
22 of 24 checks passed
@mikealfare mikealfare deleted the fixLoggerDependency branch May 13, 2024 21:00
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@colin-rogers-dbt @github-actions
remove dependency on dbt-core legacy logger (#1233)
f61f1f3 
* use dynamic schema in test_grant_access_to.py
* revert setup
* remove broken import

(cherry picked from commit d148cc3)
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees
No one assigned
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @mikealfare