Skip to content

Commit

Permalink
bump minimum php version to 7.4
Browse files Browse the repository at this point in the history
  • Loading branch information
jwong-dayspring committed Aug 14, 2023
1 parent 42b6f7d commit 5262ae2
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
1 change: 0 additions & 1 deletion .github/workflows/symfony.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
fail-fast: false
matrix:
php:
- '7.3'
- '7.4'
- '8.0'
- '8.1'
Expand Down
4 changes: 3 additions & 1 deletion DependencyInjection/DayspringLambdaExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Dayspring\LambdaBundle\DependencyInjection;

use Exception;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
Expand All @@ -16,8 +17,9 @@ class DayspringLambdaExtension extends Extension
{
/**
* {@inheritdoc}
* @throws Exception
*/
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);

Check notice on line 25 in DependencyInjection/DayspringLambdaExtension.php

View workflow job for this annotation

GitHub Actions / Qodana for PHP

Unused local variable

Unused local variable 'config'. The value of the variable is not used anywhere.
Expand Down
2 changes: 1 addition & 1 deletion Service/EchoLambdaHandlerService.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class EchoLambdaHandlerService implements LambdaHandlerServiceInterface
{

/** @var LoggerInterface $logger */
protected $logger;
protected LoggerInterface $logger;

/**
* @param LoggerInterface $logger
Expand Down
4 changes: 2 additions & 2 deletions Service/ServiceFunctionHandlerService.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ class ServiceFunctionHandlerService implements LambdaHandlerServiceInterface
{

/** @var LoggerInterface $logger */
protected $logger;
protected LoggerInterface $logger;

/** @var ContainerInterface $container */
protected $container;
protected ContainerInterface $container;


/**
Expand Down
2 changes: 1 addition & 1 deletion Service/SqsLambdaHandlerService.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class SqsLambdaHandlerService implements LambdaHandlerServiceInterface
{

/** @var LoggerInterface $logger */
protected $logger;
protected LoggerInterface $logger;

/**
* @param LoggerInterface $logger
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
}
],
"require": {
"php": ">=7.0",
"php": ">=7.4",
"ext-json": "*",
"symfony/dotenv": "^4.4|^5.0",
"symfony/framework-bundle": "^4.4|^5.0",
"symfony/yaml": "^4.4|^5.0",
Expand Down

0 comments on commit 5262ae2

Please sign in to comment.