-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example/nextjs-app-router #334
Add example/nextjs-app-router #334
Conversation
👷 Deploy request for useshoppingcart pending review.Visit the deploys page to approve it
|
Whoa, thank you! I really appreciate you. I'm gonna take a look tomorrow morning if that's okay with you 🫡 |
Hey @bhattrajat, I sent a PR to your fork bc I did a whole bunch of messy stuff. Lemme know if it works though, maybe we can move forward from there. You should be able to run the project now and not see any dependency errors |
Fix dependency error
use-shopping-cart/core/Entry.js
Outdated
@@ -1,5 +1,6 @@ | |||
import { isClient } from '../utilities/SSR' | |||
import { formatISO } from 'date-fns' | |||
// This is giving an error if I run any dev: script using pnpm | |||
// import { formatISO } from 'date-fns' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @dayhaysoos, Thanks for your commit in the fork. It fixed the error in nextjs project but since I have commented import here so I can commit my code since pre commit hook is giving me an error. I need to uncomment it before merging this PR. But if I uncomment this code and try to commit it, It is not working due to pre-commit hook which is giving me this error.
Hi, Now I am able to run the nextjs project without any error but if I try to revert back the commented code in use-shopping-cart\core\Entry.js |
@bhattrajat I just realized that Does it work after you install it yourself with this command?
|
Yes, It works 🥳. Also, I have checked all the svgs are working fine in nextjs-app-router example. Let me know if you have any suggestions/improvements. |
Thank you @bhattrajat, I'm going to go ahead and merge. Honestly I have to work on the new timestamp feature that I have in another branch so I have to play catch up before I give any feedback on improvements/suggestions for now. I really appreciate you! @all-contributors please add @bhattrajat for examples |
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @bhattrajat! 🎉 |
Changes made
Issue faced
Hi @dayhaysoos I wasn't able to run any example using pnpm dev:* since It was giving me this error
and this warning as well
I think this is related to the last commit and maybe missing dependency of date-fns?
So I have commented last committed code just to get pass the git commit.
Can you please take a look into this and my PR as well?