Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote launch url #231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miguelwicht
Copy link

These changes allow the plugin to launch content that is hosted on a remote system and provide a way to implement some kind of authorization via the GET parameters e.g. by signing the launch url.

@miguelwicht
Copy link
Author

@davidpesce Any chance this will get reviewed and merged? Happy to answer questions if there are any.

@davidpesce
Copy link
Owner

Hi @miguelwicht - Sorry for the late reply, I haven't had a chance to look into this. That said, the current plugin does allow launching of remote content.

@miguelwicht
Copy link
Author

miguelwicht commented Jul 19, 2023

@davidpesce I took another look and launching remote content does indeed work but only if you manually enter the launch url and activity Id in the form. If you try to set them via the tincan.xml file it does not because the plugin prepends the launch url with something like this: "http://moodle.docker.localhost/pluginfile.php/18/mod_tincanlaunch/content/" where "http://moodle.docker.localhost" is the url of your Moodle instance. That is why I added the check for a valid URL before updating the launch url.

This was kinda hard to debug because after the plugin prepended the string to the URL my links exceeded the 255 character limit and the returned error and link mentioned a completely unrelated problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants